optional space between /* and csslint in embedded ruleset; fixes #549 #598
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/core/CSSLint.js
Outdated
There was a problem hiding this comment.
Why not allow more than one space in the embedded ruleset? (i.e. use "*" instead of "?")
Also, it would be cool if you could add a test to tests/core/CSSLint.js to make sure the behaviour works the way you expect. 😉 Something like:
"Spaces should be allowed in embedded rulesets": function(){
var result = CSSLint.verify("/* csslint bogus, adjoining-classes:true, box-sizing:false */\n.foo.bar{}", {
"text-indent": 1,
"box-sizing": 1
});
Assert.areEqual(2, result.ruleset["adjoining-classes"]);
Assert.areEqual(1, result.ruleset["text-indent"]);
Assert.areEqual(0, result.ruleset["box-sizing"]);
}
would work.
Contributor
Author
|
Works for me. Will definitely add the test. Should we limit the amount of whitespace? /* csslint ... */Would work without an enforced convention. Is that desired behavior? |
|
I don't think I'ld use it myself, but I can't think of a particularly good reason to restrict it… Yeah, they should probably line up the |
Contributor
Author
|
Sounds good. |
|
Looks great! Thank you! |
XhmikosR
added a commit
that referenced
this pull request
Jan 9, 2016
optional space between /* and csslint in embedded ruleset; fixes #549
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pretty straightforward; most other linters I've worked with allow for a space between
/*and the linter name for embedded ruleset comments. I think csslint should support the same as a very small enhancement. Thanks for your consideration!